Remove module index anchor from import.meta.url of top-level modules.#307
Merged
Remove module index anchor from import.meta.url of top-level modules.#307
Conversation
rictic
approved these changes
May 3, 2018
| // unique keys in the registry. We don't want to see that here. Note | ||
| // that the real base URL may legitimately have an anchor, so it's not | ||
| // safe to trim the anchor of non-top-level script URLs. | ||
| url: mod.isTopLevel === true ? |
Contributor
There was a problem hiding this comment.
style nit: I definitely prefer putting parens around the ternary condition.
Contributor
justinfagnani
left a comment
justinfagnani
left a comment
There was a problem hiding this comment.
post-merge LGTM :)
justinfagnani
pushed a commit
that referenced
this pull request
Jul 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.